Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI windows encoding #174

Merged
merged 7 commits into from
Dec 12, 2022
Merged

fix CI windows encoding #174

merged 7 commits into from
Dec 12, 2022

Conversation

aogier
Copy link
Contributor

@aogier aogier commented Dec 12, 2022

This PR cherry-picks CI-related modifications @jsvine did in #173, and fix an error which bizarrely only happened on windows' CI runs (see https://github.com/aogier/markovify/actions/runs/3670909779/jobs/6205759428)

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #174 (95fdae9) into master (74696e3) will not change coverage.
The diff coverage is n/a.

❗ Current head 95fdae9 differs from pull request most recent head 1dd569e. Consider uploading reports for the commit 1dd569e to get more accurate results

@@            Coverage Diff            @@
##            master      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          313       313           
=========================================
  Hits           313       313           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jsvine jsvine merged commit 031d236 into jsvine:master Dec 12, 2022
@jsvine
Copy link
Owner

jsvine commented Dec 12, 2022

A big thanks, @aogier!

@aogier aogier deleted the 127+1-fix-windows-encoding branch December 12, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants